Skip to content

Conversation

@KeeyanGhoreshi
Copy link
Contributor

@KeeyanGhoreshi KeeyanGhoreshi commented Dec 15, 2023

Describe your changes

Adds canonical uris to questionnaire's and uses them

Issue ticket number and Jira link

REMS-400

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Copy link
Contributor

@jtquach1 jtquach1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requested changes are not related to your ticket/PR, but they are related to the extensions your PR touches. The Questionnaire.url changes you made still conform to the uri type in FHIR R4. Ditto for Questionnaire.item[sdc-questionnaire-subQuestionnaire].extension.valueCanonical.

I wasn't able to locate the original Questionnaire.extensions located at http://hl7.org/fhir/StructureDefinition/sub-questionnaire and http://hl7.org/fhir/StructureDefinition/sub-questionnaire-expand, but I found updated URLs for those extensions that conform to FHIR version 4.0.1 in the Structured Data Capture IG (mentioned under https://hl7.org/fhir/R4/questionnaire.html#scope). They seem to not be defined for FHIR version 4.0.0 for that IG, however. I was also unable to locate the sub-questionnaire and sub-questionnaire-expand extensions from https://hl7.org/fhir/R4/questionnaire.html.

I'm not entirely sure whether Questionnaire.item[sdc-questionnaire-collapsible].extension.valueCanonical is meant to be a more updated version of Questionnaire.item[sub-questionnaire-expand].extension.valueCanonical, but its required valueCode ValueSet (not valueBoolean) is binary just like a boolean. This is the spec: https://hl7.org/fhir/uv/sdc/ValueSet-collapsible.html

Copy link
Contributor

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@avirgulto avirgulto merged commit 404a5be into dev Jan 11, 2024
@avirgulto avirgulto deleted the canonical-url branch January 11, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants