-
Notifications
You must be signed in to change notification settings - Fork 2
add uris #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add uris #125
Conversation
jtquach1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested changes are not related to your ticket/PR, but they are related to the extensions your PR touches. The Questionnaire.url changes you made still conform to the uri type in FHIR R4. Ditto for Questionnaire.item[sdc-questionnaire-subQuestionnaire].extension.valueCanonical.
I wasn't able to locate the original Questionnaire.extensions located at http://hl7.org/fhir/StructureDefinition/sub-questionnaire and http://hl7.org/fhir/StructureDefinition/sub-questionnaire-expand, but I found updated URLs for those extensions that conform to FHIR version 4.0.1 in the Structured Data Capture IG (mentioned under https://hl7.org/fhir/R4/questionnaire.html#scope). They seem to not be defined for FHIR version 4.0.0 for that IG, however. I was also unable to locate the sub-questionnaire and sub-questionnaire-expand extensions from https://hl7.org/fhir/R4/questionnaire.html.
I'm not entirely sure whether Questionnaire.item[sdc-questionnaire-collapsible].extension.valueCanonical is meant to be a more updated version of Questionnaire.item[sub-questionnaire-expand].extension.valueCanonical, but its required valueCode ValueSet (not valueBoolean) is binary just like a boolean. This is the spec: https://hl7.org/fhir/uv/sdc/ValueSet-collapsible.html
...library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-Prescriber-Knowledge-Assessment-TIRF.json
Outdated
Show resolved
Hide resolved
...library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-Prescriber-Knowledge-Assessment-TIRF.json
Outdated
Show resolved
Hide resolved
...library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-Prescriber-Knowledge-Assessment-TIRF.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-PrescriberEnrollment-TIRF.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/Turalio/R4/resources/Questionnaire-R4-TuralioProgressNote.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/Turalio/R4/resources/Questionnaire-R4-TuralioProgressNote.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-PrescriberEnrollment-TIRF.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/TIRF/R4/resources/Questionnaire-R4-TIRF.json
Outdated
Show resolved
Hide resolved
src/cds-library/CRD-DTR/Turalio/R4/resources/Questionnaire-R4-Turalio.json
Outdated
Show resolved
Hide resolved
b5106fb to
d5ec150
Compare
avirgulto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Describe your changes
Adds canonical uris to questionnaire's and uses them
Issue ticket number and Jira link
REMS-400
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review