Skip to content

Conversation

@KeeyanGhoreshi
Copy link
Contributor

Describe your changes

Takes code from all three currently supported hooks and puts the shared bits into functions in a separate file. This removes most of the duplicate code between hooks. The changes should not functionally change anything, the workflow should proceed as expected.

Issue ticket number and Jira link

REMS-557

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@plarocque4 plarocque4 merged commit 62e41f3 into dev Jan 10, 2024
@plarocque4 plarocque4 deleted the generalize-hooks branch January 10, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants