Skip to content

Conversation

@plarocque4
Copy link
Contributor

@plarocque4 plarocque4 commented Mar 6, 2024

Describe your changes

Add support for Addyi, a medication that does not have ETASU and only has a medication guide.
This must be tested with the no_etasu branch of test-ehr and adding the new FHIR resources.
It is also necessary to remove the remsadmin database from mongo before starting rems-admin.

Issue ticket number and Jira link

REMS-616

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

…se, remove unused imports, and change double equals to triple equals
Copy link
Contributor

@avirgulto avirgulto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected for Addyi, code looks good

@plarocque4 plarocque4 dismissed jtquach1’s stale review March 19, 2024 14:50

The requested changes have been made.

@plarocque4 plarocque4 merged commit 023ea6f into dev Mar 19, 2024
@plarocque4 plarocque4 deleted the no_etasu branch March 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants