Skip to content

Conversation

@jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented Jun 12, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

  • Refactored code
  • Included the absolute links seen on the (Turalio) Patient Enrollment card for the Patient Status Update card

Related rems-cds-hooks PR (pull down this repo's branch): mcode/rems-cds-hooks#20

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

REMS-693

REMS-692

How to manually test

  1. Use dev for all other repos except for rems-admin and rems-cds-hooks (inside src/cds-hooks)
  2. Clear out rems-admin and everything else in the settings tab in request-generator, also any local/session storage that affects the CDS hooks strings in the settings page
  3. Select Jon Snow and Turalio
  4. Click Send Rx
  5. Click Sign Order
  6. Fill out the Patient Enrollment Form
  7. Go back to request-generator and select Jon Snow (to send the patient-view hook)
  8. You should see a card with the Patient Status Update form with the dropdown containing informational links. This can also be verified in the Network tab's rems-patient-view network request response.
  9. Go into the settings panel. Under the "Hook to send when selecting a patient" dropdown it is by default set to patient-view. Select encounter-start.
  10. Redo steps 7-8 with the encounter-start hook.

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 force-pushed the update-encounter-start-and-patient-view-cards branch from 065d815 to 95845a5 Compare June 13, 2024 20:27
@jtquach1 jtquach1 force-pushed the update-encounter-start-and-patient-view-cards branch from 95845a5 to fb5f94e Compare June 13, 2024 20:28
@jtquach1 jtquach1 marked this pull request as ready for review June 14, 2024 17:02
@jtquach1
Copy link
Contributor Author

Not sure why the macos tests are failing, I can run npm test on my machine fine

@avirgulto avirgulto self-assigned this Jun 17, 2024
Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jtquach1
Copy link
Contributor Author

will update the commit to rems-cds-hooks once that's pointing to the same commit on origin/dev there

@jtquach1 jtquach1 merged commit dcf8976 into dev Jun 28, 2024
@jtquach1 jtquach1 deleted the update-encounter-start-and-patient-view-cards branch June 28, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants