Skip to content

Conversation

@smalho01
Copy link
Collaborator

@smalho01 smalho01 commented Jul 8, 2024

Describe your changes

Expose ports to add second rems-admin to the stack

run this PR alongside: mcode/rems-setup#49

Issue ticket number and Jira link

https://jira.mitre.org/browse/REMS-685

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1
Copy link
Contributor

jtquach1 commented Jul 9, 2024

Looks good. I was able to change the order-sign hook endpoint (port) and send a second patient status update form from port 8095 after sending the first one from port 8090. Also checked the Network tab to see the two rems-order-sign requests were sent from a different rems-admin.

@smalho01 smalho01 merged commit aa6f706 into dev Jul 12, 2024
@smalho01 smalho01 deleted the rems-admin2 branch July 12, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants