Skip to content

Conversation

@jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented Jul 25, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Updated environment variables used in mcode/rems-smart-on-fhir#105 and mcode/pims#86

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-710
https://jira.mitre.org/browse/REMS-712

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 marked this pull request as draft July 25, 2024 22:03
@jtquach1 jtquach1 marked this pull request as ready for review July 25, 2024 22:52
@jtquach1 jtquach1 force-pushed the update-etasu-check-to-use-intermediary branch from 1049c9d to cf93ad1 Compare July 30, 2024 15:26
@jtquach1 jtquach1 changed the base branch from dev to rems-intermediary-mongo July 30, 2024 15:26
@jtquach1 jtquach1 force-pushed the update-etasu-check-to-use-intermediary branch from cf93ad1 to c2b5a9f Compare July 30, 2024 15:27
@jtquach1
Copy link
Contributor Author

This is rebased off rems-intermediary-mongo currently since I'm using Docker Compose to run MongoDB

@jtquach1 jtquach1 force-pushed the update-etasu-check-to-use-intermediary branch from c2b5a9f to 2c7c517 Compare July 30, 2024 17:54
@plarocque4 plarocque4 merged commit 473fe18 into rems-intermediary-mongo Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants