Skip to content

Conversation

@jtquach1
Copy link

@jtquach1 jtquach1 commented Sep 3, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

In the Task page, the Task component's dropdown menu now has the R4 Practitioner and R4 Patient's names (first/last, first/middle/last) in parentheses, if they exist, in the dropdown options.

How to observe/manually test:

  1. Go to localhost:3000, authenticate
  2. Open the Network tab in DevTools
  3. Click View Tasks (to see all tasks regardless of patient as the current Practitioner)
  4. You will see a GET request for pra1234 done to the test-ehr in the Headers tab, and under the Initiator tab done by TasksSection at line 141.
  5. Click Assign on any task
  6. You will see options for Jane Doe or Jon Stark Snow/Alice Smith. Assigning functionality is also still intact.
  7. Go to the Patient Select tab and select either Jon Snow or Alice Smith, then back to the Tasks tab to see that the Tasks have been filtered by patient
  8. Do steps 4-6.

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-747

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 self-assigned this Sep 5, 2024
Copy link

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@plarocque4 plarocque4 merged commit 1b589e2 into dev Sep 6, 2024
@plarocque4 plarocque4 deleted the patient-portal-task-assignee-string-changes branch September 6, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants