implement missing libraries #21

mcquenji · 2025-06-15T15:15:45Z

The infinite loop was caused by the catch target not being popped after entering it. This caused all exceptions thrown within the catch block to just jump to the start of the block, thus infinitley calling itself instead of just erroring out

Closes: #25 #24 #23

BREAKING: Made `returnType` required for bindings BREAKING: Added a custom lint rule to ban `toString()` on any instances of `Type`

- DateTime lib is still incomplete BREAKING: Structs are now generic and require a toDart and fromDart function upon creation (does not apply to shallow structs)

Copilot

Pull Request Overview

This PR implements several missing standard library modules for the dscript language, introducing comprehensive support for filesystem operations, HTTP requests, JSON handling, UTF-8 encoding, Base64 encoding, and utility functions for lists, maps, and dynamic values.

Refactored the Struct type system to support typed conversion between DSL and Dart objects
Implemented new standard library modules: fs, http, json, utf8, base64, list, map, and dynamic
Enhanced the RuntimeBinding system with middleware support and improved parameter handling
Added comprehensive documentation and custom linting rules

Reviewed Changes

Copilot reviewed 47 out of 51 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`lib/src/types.dart`	Enhanced Struct type with generic support and predefined structs for HTTP responses, JSON, DateTime, and Duration
`lib/src/stdlib/*.dart`	Implemented new standard library modules with comprehensive functionality
`lib/src/bindings.dart`	Refactored RuntimeBinding with middleware support and improved parameter validation
`lib/src/contract_builder.dart`	Updated contract builder to support new parameter naming and return type specification
`pubspec.yaml`	Added new dependencies (dio, custom_lint) and removed unused stack dependency
`docs/`	Updated documentation with comprehensive standard library reference
`custom_lints/`	Added custom linting rules to prevent type.toString() usage in web builds

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-17T01:13:31Z

lib/src/stdlib/list.dart

+    name: 'add',
+    function: (List<dynamic> list, dynamic element) => list.add(element),
+    positionalParams: {
+      'list': ListType(elementType: const DynamicType()),


The 'add' binding is missing the 'element' parameter in positionalParams. This will cause a runtime error when validating arguments since the function expects 2 parameters but only 1 is declared.

Suggested change

'list': ListType(elementType: const DynamicType()),

'list': ListType(elementType: const DynamicType()),

'element': const DynamicType(),

Copilot · 2025-08-17T01:13:31Z

lib/src/stdlib/list.dart

+    name: 'remove',
+    function: (List<dynamic> list, dynamic element) => list.remove(element),
+    positionalParams: {
+      'list': ListType(elementType: const DynamicType()),


The 'remove' binding is missing the 'element' parameter in positionalParams. This will cause a runtime error when validating arguments since the function expects 2 parameters but only 1 is declared.

Suggested change

'list': ListType(elementType: const DynamicType()),

'list': ListType(elementType: const DynamicType()),

'element': const DynamicType(),

Copilot · 2025-08-17T01:13:32Z

lib/src/stdlib/dynamic.dart

+        value,
+        'value',
+        'Value must be a collection or string to get length.',
+      );


[nitpick] Consider using a more efficient type check pattern like 'value.length' directly with try-catch, which would avoid multiple type checks and leverage Dart's dynamic dispatch.

Suggested change

);

try {

return value.length;

} catch (e) {

throw ArgumentError.value(

value,

'value',

'Value must have a length property.',

);

}

Copilot · 2025-08-17T01:13:32Z

lib/src/vm/vm_impl.dart

            store(frame, index, stack.removeLast());
+
+            // pop this catch target to avoid infinite loops if the catch block throws again
+            if (catchTargets.isNotEmpty) catchTargets.removeLast();


This comment and logic suggest removing catch targets unconditionally during exception handling, but this could break proper exception handling flow. The catch target should only be removed when the catch block completes successfully, not during exception processing.

Suggested change

if (catchTargets.isNotEmpty) catchTargets.removeLast();

// Do not remove the catch target here; it should only be removed when the catch block completes successfully (in endTry).

Copilot · 2025-08-17T01:13:32Z

lib/src/types.dart

+
+  static Map<String, dynamic> _shallowFromDart<T>(T obj) {
+    throw UnimplementedError(
+        r'Cannot convert Dart object to shallow struct. Use `$Type.lookup` to get the resolved struct and call `fromDart` on it.');


The error message references '$Type.lookup' method which may not exist or be accessible to users. Consider providing a more actionable error message with the correct method name or approach.

Suggested change

r'Cannot convert Dart object to shallow struct. Use `$Type.lookup` to get the resolved struct and call `fromDart` on it.');

'Cannot convert shallow struct to Dart object. Ensure you are using a fully resolved struct and call `toDart` on it.');

}

static Map<String, dynamic> _shallowFromDart<T>(T obj) {

throw UnimplementedError(

'Cannot convert Dart object to shallow struct. Ensure you are using a fully resolved struct and call `fromDart` on it.');

Copilot · 2025-08-17T01:13:32Z

lib/src/stdlib/fs.dart

+      final contents = dir.listSync();
+      return contents
+          .whereType<File>()
+          .map((file) => file.path)


The function documentation says it 'Lists the contents of a directory' but the implementation only returns files, not directories. Either update the documentation or include directories in the result.

Suggested change

.map((file) => file.path)

.map((entity) => entity.path)

Copilot · 2025-08-17T01:13:33Z

lib/src/types.dart


  /// Default structs defined within the language.
-  static final defaults = [error];
+  static final defaults = [error, httpResponse, json, duration, dateTime];


The 'mapEntry' struct is defined but not included in the defaults list, which means it won't be available for type resolution during compilation and runtime.

mcquenji added 2 commits June 15, 2025 13:21

feat(stdlib): expand standard library

ebc4f1e

feat(stdlib): support binding middleware and custom stdlibs

ce70c9e

mcquenji added the enhancement New feature or request label Jun 15, 2025

mcquenji added 5 commits June 16, 2025 17:37

docs(stdlib): add script for generating docs

8cea24d

fix(compiler): actually handle assignments

f3e1d25

fix(stdlib): throw when trying to get length of an unsopported type

ec76354

docs: update docs

f6a74bc

This comment was marked as resolved.

Sign in to view

chore(stdlib): remove print statements

3c6209b

mcquenji changed the title ~~Enhance stdlib~~ implement missing libraries Jun 16, 2025

mcquenji requested a review from Copilot June 16, 2025 23:16

This comment was marked as outdated.

Sign in to view

mcquenji added 4 commits June 18, 2025 05:54

feat(stdlib): implement http bindings

8416483

fix(compiler): make for in loops work

228865f

docs(stdlib): add documentation for customizing the stdlib

b648a35

feat(stdlib): implement json & utf8 lib

7674bd1

mcquenji added the stdlib This issue is about the standard library label Jun 18, 2025

mcquenji added 7 commits June 18, 2025 19:05

ci(docs): auto upddate docs

56a3d68

docs: add motivation to readme

bd7f83e

feat(stdlib): implement base64 bindings

fde3a1a

feat(stdlib): add more collection utils

3642ba6

Closes: #25 #24 #23

fix!: refrain from type inference by name

137afee

BREAKING: Made `returnType` required for bindings BREAKING: Added a custom lint rule to ban `toString()` on any instances of `Type`

ci: prevent reporter from failing and fix fail checks

2509d98

ci: huh

35bf347

mcquenji linked an issue Aug 11, 2025 that may be closed by this pull request

[feature] .copy() for collections #24

Open

feat!: enhance Struct with toDart/fromDart functions

b73e686

- DateTime lib is still incomplete BREAKING: Structs are now generic and require a toDart and fromDart function upon creation (does not apply to shallow structs)

mcquenji requested a review from Copilot August 17, 2025 01:11

Copilot AI reviewed Aug 17, 2025

View reviewed changes

ci: fix failing unit test and update noteKeywords in .versionrc

c8f3914

mcquenji added 2 commits August 21, 2025 19:16

chore: switch to source gen for stdlib (WIP)

1705296

chore: use new sourcegen version

fe4a0b6

mcquenji force-pushed the stdlib branch from ecd7722 to fe4a0b6 Compare August 23, 2025 01:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

implement missing libraries #21

implement missing libraries #21

Uh oh!

mcquenji commented Jun 15, 2025 •

edited

Loading

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Copilot AI Aug 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	'list': ListType(elementType: const DynamicType()),
	'list': ListType(elementType: const DynamicType()),
	'element': const DynamicType(),

-      );
+      try {
+        return value.length;
+      } catch (e) {
+        throw ArgumentError.value(
+          value,
+          'value',
+          'Value must have a length property.',
+        );
+      }

	if (catchTargets.isNotEmpty) catchTargets.removeLast();
	// Do not remove the catch target here; it should only be removed when the catch block completes successfully (in endTry).

Uh oh!

implement missing libraries #21

Are you sure you want to change the base?

implement missing libraries #21

Uh oh!

Conversation

mcquenji commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mcquenji commented Jun 15, 2025 •

edited

Loading