Enables S3 native state locking on the Terraform backend#20
Merged
Conversation
Terraform Plan 📖
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables S3 native state locking on the Terraform backend to prevent concurrent
terraform applyruns(e.g. a local apply racing a GitHub Actions apply) from corrupting state.
Closes LAD-283.
Changes
terraform/main.tf— Addeduse_lockfile = trueto the S3 backend block. Bumpedrequired_versionfrom>= 1.5to>= 1.10sinceuse_lockfileis a Terraform 1.10 feature..github/workflows/ci.yml+deploy.yml— BumpedTERRAFORM_VERSIONfrom"1.5"to"1.10"tomatch the new minimum.
Why S3 native locking over DynamoDB?
Terraform 1.10 added lockfile-based locking for the S3 backend, which keeps the lock in the same bucket
as the state. This removes the need for a separate
aws_dynamodb_tableresource and its associated IAMpermissions — one less thing to provision and pay for.
Operator steps after merge
Anyone with a local Terraform install needs to upgrade to 1.10+ — the Homebrew core
terraformformulais frozen at 1.5.7 due to the HashiCorp BSL license change, so use the official tap or
tfenv: