Skip to content

[#79] Update README.md#106

Merged
Berdir merged 2 commits intomd-systems:pattern-config-entities-simplified-uifrom
juampynr:update-readme
Dec 26, 2015
Merged

[#79] Update README.md#106
Berdir merged 2 commits intomd-systems:pattern-config-entities-simplified-uifrom
juampynr:update-readme

Conversation

@juampynr
Copy link

  • Remove obsolete references.
  • Adjust functions that changed.

* Remove obsolete references.
* Adjust functions that changed.
README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are many ways to generate URL's, and e.g. in case of entities, the easiest is $entity->toUrl(). I'd recommend to just write something like Drupal's URL and Link APIs. Maybe we can even find a documentation page for that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any documentation that centralizes this, but instead an issue where core devs are debating that there are way too many ways to generate a link :-D: https://www.drupal.org/node/2491981

I will follow your advice and change the wording.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about it now @Berdir? I removed the links to the API functions as there are many ways to generate links. We could add a documentation link when there is one.

Berdir added a commit that referenced this pull request Dec 26, 2015
@Berdir Berdir merged commit 3e692c7 into md-systems:pattern-config-entities-simplified-ui Dec 26, 2015
@Berdir
Copy link
Member

Berdir commented Dec 26, 2015

Yeah, that's a "great" issue ;)

@juampynr juampynr deleted the update-readme branch December 26, 2015 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants