Fix form redirection after bulk delete#99
Conversation
The Bulk Delete form was redirecting to the Bulk Update form instead of back to Bulk Delete.
|
Nice find. Maybe we can extend the bulk delete test to to make sure we have a test for this? |
|
@Berdir, when I looked at the test I saw the following: The above checks the basics: that the form does the deletion. I don't feel right for adding a check to see that the form redirected where it should. I think that it is a matter of me understanding how far do we want to go with the testing coverage. Do we want to cover every line of logic? If that is the case, then my worry is that we may end up with such a huge test suite that it would be hard to maintain. I personally prefer to test bits of the module that are tricky to understand and prone to break. What do you think? cc @EclipseGc |
|
The fact that it was non-trivial enough for us to do it incorrectly is proof enough for me that it would make sense to have it covered by tests. We also have the assertion for the confirmation message which is equally trivial. And it just requires a single line. If it would be complicated to test, that could change things.. |
|
Fair enough. Adding... |
|
Added! |
Fix form redirection after bulk delete
|
Thanks, merged. |
The Bulk Delete form redirects to the Bulk Update form after performing the deletion. This pull request fixes it.