Update nodejs compat for javascript.function.rest_parameters #1744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit documents Node.js compatibility for function rest parameters. This mainly depends on V8 but I tracked the relevant Node versions, commits and PRs. Note that I used `4` for the version of the flag addition because `3` corresponds to the io.js fork and is not recognized as a valid `nodejs` version by the linter. Flagged support (io.js 3.0.0, V8 4.4): - [Node.js changelog entry for version 3.0.0](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_IOJS.md#2015-08-04-version-300-rvagg) - [Pull Request](nodejs/node#2022) - [Commit, with anchor to relevant line](nodejs/node@70d1f32f56#diff-b2e04de0d939630d882245c2243e7e47R200) Stable support (Node.js 6.0.0, V8 4.7): - [Node.js changelog entry for version 6.0.0](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#2016-04-26-version-600-current-jasnell) - [Pull Request](nodejs/node#4106) - [Commit, with anchor to relevant line](nodejs/node@8a43a3d#diff-b2e04de0d939630d882245c2243e7e47R217) Flag removal (Node.js 6.0.0, V8 4.9): - [Node.js changelog entry for version 6.0.0](https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V6.md#2016-04-26-version-600-current-jasnell) - [Pull Request](nodejs/node#4722) - [Commit, with anchor to relevant line](nodejs/node@069e02a#diff-b2e04de0d939630d882245c2243e7e47L221)
2 tasks
Elchi3
added
the
data:js
Elchi3
approved these changes
Apr 11, 2018
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Thanks for contributing to MDN browser-compat-data and especially for your detailed research when this was exposed in which way.
I removed the notes with the references to the PRs/commits that proof the information, because we do not generally add this kind of info to the data . It is good to have it as (meta) info in this PR, though, so it can be seen when using blame, for example.
Thanks again for your work! 🎉
Contributor
Author
|
Thanks for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit documents Node.js compatibility for function rest
parameters. This mainly depends on V8 but I tracked the relevant Node
versions, commits and PRs.
Note that I used
4for the version of the flag addition because3corresponds to the io.js fork and is not recognized as a valid
nodejsversion by the linter.
Flagged support (io.js 3.0.0, V8 4.4):
Stable support (Node.js 6.0.0, V8 4.7):
Flag removal (Node.js 6.0.0, V8 4.9):