take Kumascript Dockerfile from kuma #1249
Conversation
|
@peterbe Do I need to create/update some settings file for |
Ah, yeah, it looks like we're not using |
| RUN npm config set python /usr/bin/python2.7 && \ | ||
| # install the Node.js dependencies, | ||
| # with versions specified in npm-shrinkwrap.json | ||
| npm ci && \ |
There was a problem hiding this comment.
npm ci is an alias to npm clean‑install
| npm ci && \ | |
| npm clean-install && \ |
There was a problem hiding this comment.
@ExE-Boss It's my understanding that npm ci is the proper command. In fact, I don't see any npm documentation on a npm clean-install command, and I think the ci references continuous integration rather than clean install. In any case, I'm going to keep this as it is, since changing it would be outside the scope of this PR anyway.
There was a problem hiding this comment.
Oh! Good to know, thanks @ExE-Boss, but I'll leave that for another PR.
|
@peterbe I removed you as a reviewer since I realized that I was pulling your mind into this realm when you've already got so much on your plate, but of course feel free to review if you'd like to. |
3 participants
This is a companion PR to mdn/kuma#5902. It should be reviewed and merged along with that PR.
This PR moves the Kumascript
Dockerfile(and associatedREADME.mdfile) from the Kuma repo into this repo where it belongs. It also takes advantage of the newmake build-kumascript-with-all-tagscommand provided by mdn/kuma#5902.