Merged
Conversation
Proposes a unified ProviderError type with ErrorKind categorization, preserving provider-specific codes while enabling programmatic handling. Six-phase incremental migration plan, each phase independently buildable. https://claude.ai/code/session_0115EjMcwabSsDr869GXPvFi
- Add Is() method to ProviderError for correct errors.Is sentinel compat - Add ErrKindCanceled to distinguish context cancellation from network errors - Move httpStatusToKind out of pkg/model into per-provider errors.go - Add WrapError() escape hatch for migration safety - Note CoinGecko's different client pattern (get() vs doRequest) - Gate Phase 3 explicitly on full Phase 2 completion - Fix Retryable() note: 5xx retryable but callers must backoff/cap retries - Cover ComparePrices facade ItemError construction in Phase 5 - Add test requirement to Phase 2 checklist https://claude.ai/code/session_0115EjMcwabSsDr869GXPvFi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes a unified ProviderError type with ErrorKind categorization,
preserving provider-specific codes while enabling programmatic handling.
Six-phase incremental migration plan, each phase independently buildable.
https://claude.ai/code/session_0115EjMcwabSsDr869GXPvFi