Add Cabinet::all_files, method to extract all files in an archive sequentially and efficiently#34
Merged
mdsteele merged 2 commits intomdsteele:masterfrom Jul 16, 2025
Merged
Conversation
Currently, there is no method to retrieve all files in the cabinet. Library users who want to extract all files need to iterate using Cabinet::read_file, which throws away bytes up to where the target file is located in the decompressed stream, which is inefficient. This commit adds a new method Cabinet::all_files() that returns an AllFiles struct. When library user repeatedly calls next_file method on it, it yields tuples of (file_entry, reader) for each file in the cabinet.
Owner
|
Thanks, this seems reasonable. Just need to make sure |
Contributor
Author
|
Thank you. Fixed fmt and lints in latest commit. Took the liberty to to fix a couple lints that came up in ctype.rs and cabinet.rs that are not strictly related to this feat. Hope that's fine with you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is no method to retrieve all files in the cabinet. Library users who want to extract all files need to iterate using Cabinet::read_file, which throws away bytes up to where the target file is located in the decompressed stream, which is inefficient.
This PR adds a new method Cabinet::all_files that returns an AllFiles struct. When library user repeatedly calls next_file method on it, it yields tuples of (file_entry, reader) for each file in the cabinet.
fixes #33
fixes #24