Open
Conversation
mdsteele
reviewed
Aug 10, 2025
| /// The actual maximum supported is 0x1ffff blocks, or 4gb of uncompressed data. | ||
| fn recalculate_block_size(compression_type: CompressionType, uncompressed_size: u32, block_size: u32) -> u32 { | ||
| match compression_type { | ||
| CompressionType::MsZip => { |
Owner
There was a problem hiding this comment.
Why does this recalculation not apply to other compression types?
|
|
||
| /// Re-calculate the real number of blocks. Since the cabinet header num_data_blocks is limited to 0xffff | ||
| /// The actual maximum supported is 0x1ffff blocks, or 4gb of uncompressed data. | ||
| fn recalculate_block_size(compression_type: CompressionType, uncompressed_size: u32, block_size: u32) -> u32 { |
Owner
There was a problem hiding this comment.
I'm a little confused by the naming here. Does this function calculate the size of each block, or the number of blocks?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding decompress support for mszip compresion.