Link to Call for Speakers

[NataliiaPodp]

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings
• My changes take different screen sizes into account
• My changes are backward compatible
  • I have not changed any parameter names
  • I have not changed any translation keys
• My changes conform to the contributing guidelines (CONTRIBUTING.md)

Desktop view:

Mobile view:

Default:

[lukket]

I have some general thoughts here:

1. The two CTAs now have the same weight, both look the same important. Is this what we want to archive @ThomasPe? Or should the Call for Speakers (CFS) be less prominent? (We could ask Daria for some input here).
2. I would prefer to make it more explicit and instead of naming it 'secondary', name it Call for Speakers or CFS. If people misuse is, it's fine. But an explicit naming documents the actual intention.

[lukket]

Please add a test to ensure the CFS button is visible when used.

[ThomasPe]

1. The two CTAs now have the same weight, both look the same important. Is this what we want to archive @ThomasPe? Or should the Call for Speakers (CFS) be less prominent? (We could ask Daria for some input here).

having a visual hierarchy would make sense, yes. can we put it on the right, and perhaps make the register button more prominent, e.g. by using the accent color as background with white text. what do you think?

2. I would prefer to make it more explicit and instead of naming it 'secondary', name it Call for Speakers or CFS. If people misuse is, it's fine. But an explicit naming documents the actual intention.

CFS is just one of the possible usecases I have in mind, could also be something like "Join Newsletter", "Gewinnspiel" or similar things you want to highlight.
What happens to the primary URL if Eventbrite ID is set, is it being ignored?

[lukket]

CFS is just one of the possible usecases I have in mind, could also be something like "Join Newsletter", "Gewinnspiel" or similar things you want to highlight.

As already discussed with @NataliiaPodp, I still would prefer to make it explicit, because if the meaning changes to something other the CFS, then it's also likely that the layout and design should change. A newsletter may get its own card on every page with an input field, a Gewinnspiel is likely to require more attention than a CFS button. If people misuse this button, it's up to them. But if we want to keep the quality high, it's up to us to make things explicit and to avoid the uncertainty.

What happens to the primary URL if Eventbrite ID is set, is it being ignored?

Yes.

[ThomasPe]

I think a general CallForAction button would make sense since I don't think we can create custom solutions for all kinds different links. But I'm also OK with renaming it if you two agree.

[NataliiaPodp]

@ThomasPe @lukket something like this?

[ThomasPe]

I like it

[lukket]

I think a general CallForAction button would make sense since I don't think we can create custom solutions for all kinds different links. But I'm also OK with renaming it if you two agree.

My point is that having a CFS button or one (!) secondary (!) general purpose CTA button are two different requirements that require different solutions. Currently, we mix up both. If we want to provide one secondary general purpose CTA button, let's also translate it like this. There might be a comment to hint how to use it, but the CFS is then just one of many options and shouldn't be part of the core theme. Instead, it could be part of the demo.

@ThomasPe @lukket something like this?

To me, it looks not consistent anymore, because the two 'Jetzt registrieren' button have a different look now (even without secondary CTA button?). But it doesn't matter, for a professional opinion I would ask Daria 😉.