Update ginkgo v2#69
Merged
openshift-merge-robot merged 5 commits intomedik8s:mainfrom Feb 2, 2023
Merged
Conversation
1 task
razo7
force-pushed
the
update-ginkgo-v2
branch
from
d8ed845 to
69da861
Compare
Member
Author
|
/retest |
Ginkgo v1.16.5 is the last Ginkgo v1 release, Oct 2021, before bumping to a new major release which has been introduced on 2022. Ginkgo v2.8.0 is the latest version and it has been releasd on Jan 2023.
Add missing and remove unused modules, make vendored copy of dependencies, and verify dependencies have expected content.
razo7
force-pushed
the
update-ginkgo-v2
branch
from
69da861 to
b308ccd
Compare
clobrano
reviewed
Feb 1, 2023
Contributor
clobrano
left a comment
clobrano
left a comment
There was a problem hiding this comment.
/lgtm
Giving others a chance to review as well, feel free to unhold
/hold
slintes
reviewed
Feb 1, 2023
| .PHONY: test-no-verify | ||
| test-no-verify: manifests generate go-verify fmt vet envtest ginkgo ## Generate and format code, and run tests | ||
| ACK_GINKGO_DEPRECATIONS=$(GINKGO_VERSION) KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir $(LOCALBIN))" $(GINKGO) -v -r --keepGoing -requireSuite ./api/... ./controllers/... -coverprofile cover.out | ||
| ACK_GINKGO_DEPRECATIONS=$(GINKGO_VERSION) KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path --bin-dir $(LOCALBIN))" $(GINKGO) -v -r --keep-going -require-suite ./api/... ./controllers/... -coverprofile cover.out |
Member
There was a problem hiding this comment.
probably ACK_GINKGO_DEPRECATIONS can be removed?
| ACK_GINKGO_DEPRECATIONS=$1 ./bin/ginkgo/$1/ginkgo $NO_COLOR -v -r --keepGoing -requireSuite ./test/e2e | ||
| # --keep-going: don't stop on failing suite | ||
| # -require-suite: fail if tests are not executed because of missing suite | ||
| ACK_GINKGO_DEPRECATIONS=$1 ./bin/ginkgo/$1/ginkgo $NO_COLOR -v -r --keep-going -require-suite ./test/e2e |
Use name for suites
Not supported in Ginkgo v2
Ginkgo v2 supports different naming for flags
razo7
force-pushed
the
update-ginkgo-v2
branch
from
b308ccd to
c2a404b
Compare
razo7
force-pushed
the
update-ginkgo-v2
branch
from
c2a404b to
8d8bd9a
Compare
Member
Author
|
/retest |
slintes
approved these changes
Feb 2, 2023
Member
slintes
left a comment
slintes
left a comment
There was a problem hiding this comment.
please remove the last line from the description 😉
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
|
/unhold |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NMO has been using the last Ginkgo v1 version,
v1.16.5, from Oct 2021.This PR bumps to a new major release of Ginkgo, and to the latest Ginkgo version, v2.8.0.
ginkgotoginkgo/v2make go-verify