add Google Analytics with consent banner#90
Merged
andymeierdev merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
🍹
|
minniemeierdev
approved these changes
Apr 15, 2026
minniemeierdev
left a comment
There was a problem hiding this comment.
The implementation looks solid. Tests pass, the cookie banner handles consent well and correctly persists via localStorage. Using Pulumi correctly to pass the config too. I love the fix to prevent default click navigation on article cards as well!
One thing to keep in mind for future PRs: since Datastar allows navigating without full page reloads, gtag('config', '<id>') is only firing on the initial page load. Google Analytics won't natively track subsequent page navigations over Datastar swaps unless you emit a manual page_view event to gtag on Datastar swap events or URL changes. For now this gets tracking up and running!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
googleAnalytics:measurementId)