Merged
Conversation
🍹
|
minniemeierdev
requested changes
Apr 15, 2026
minniemeierdev
left a comment
There was a problem hiding this comment.
The code works well and successfully hashes the assets. However, dotnet publish automatically generates pre-compressed .br and .gz files for these assets in wwwroot. Your FAKE script copies the hashed assets but leaves the pre-compressed versions behind, meaning the server won't serve the compressed assets when requested by the fingerprinted name.
Please update the fingerprintAssets function in Build/Program.fs to copy the .br and .gz files alongside the hashed file, for example:
let fingerprintedPath = fingerprintedFilePath path hash
File.Copy(path, fingerprintedPath, true)
if File.Exists(path + ".br") then File.Copy(path + ".br", fingerprintedPath + ".br", true)
if File.Exists(path + ".gz") then File.Copy(path + ".gz", fingerprintedPath + ".gz", true)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asset-manifest.jsonVerification