Create a helper module to reduce test duplication

[brunoocasali]

The general idea is to change tests from this:

  it 'searches with index with searchableAttributes setting' do
    response = index.update_searchable_attributes(['title', 'info.comment'])
    index.wait_for_task(response['uid'])
    response = index.add_documents(documents)
    index.wait_for_task(response['uid'])

    response = index.search('An awesome')

    expect(response['hits'].count).to eq(1)
  end

to this:

  it 'searches with index with searchableAttributes setting' do
    index.update_searchable_attributes(['title', 'info.comment']).then(&method(:wait_for_it))
    index.add_documents(documents).then(&method(:wait_for_it))

    response = index.search('An awesome')

    expect(response['hits'].count).to eq(1)
  end

or this:

  it 'searches with index with searchableAttributes setting' do
    wait_for_it index.update_searchable_attributes(['title', 'info.comment'])
    wait_for_it index.add_documents(documents)

    response = index.search('An awesome')

    expect(response['hits'].count).to eq(1)
  end

[curquiza]

Thanks for this addition 🚀

• Why is this going to be merged to bump-meilisearch-v0.27.0 since it's not related to v0.27.0? Couldn't we merge it to main, and then, merge the commit from merge to bump-meilisearch-v0.27.0? 😊
• Why not changing the tests in the same PR? 😇

[brunoocasali]

@curquiza

Why not changing the tests in the same PR? 😇

I was thinking to change all the tests after this branch is merged 😈, but I prefer to keep it simple to make it understandable, small PRs lead to better reviews!

Why is this going to be merged to bump-meilisearch-v0.27.0 since it's not related to v0.27.0? Couldn't we merge it to main, and then, merge the commit from merge to bump-meilisearch-v0.27.0? 😊

Not sure why 🤔, I think I did that because of the other branches (I opened all of them on the same day). But I'll apply your suggestion!

[curquiza]

I was thinking to change all the tests after this branch is merged 😈, but I prefer to keep it simple to make it understandable, small PRs lead to better reviews!

👍

Not sure why 🤔, I think I did that because of the other branches (I opened all of them on the same day). But I'll apply your suggestion!

For the same reason "small PRs lead to better reviews" I think we should put to bump-meilisearch-v0.27.0 only changes related to v0.27.0, otherwise the final review of bump-meilisearch-v0.27.0 will be less easy

[bidoubiwa]

LGTM 🔥🔥

[brunoocasali]

bors merge

[meili-bors]

Build succeeded:

• integration-tests (ruby 2.6)
• integration-tests (ruby 2.7)
• integration-tests (ruby 3.0)
• linter-check