Fix transporter item box color rendering #8521
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Here are screenshots as well of the before and after.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Closes #8502
In this PR, I am fixing an issue with the Logistical Transporter’s traveling item overlay ("transporter box") always rendered using a grey tint instead of the sorter-assigned color.
The root cause was that ModelTransporterBox#renderToBuffer ignored the color parameter passed from the renderer and instead hardcoded the tint to 0xFFFFFFFF. This was causing all transporter boxes to appear identical with a light gray box color regardless of the filter color actually being used.
I tested the solution in a dev environment and everything was working correctly after the fix.