Skip to content

Return default response when pigeon client reach timeout #2

@NurfitraPujo

Description

@NurfitraPujo

Issue
Currently in pigeon, if http client reaches timeout before remote endpoint is responding it defaults to returning nil. This may be hinder users that is migrating to pigeon from other http client. This was because when there is existing implementation that checks whether response code is 2xx response.code now will raise an error undefined code for Nil::Class which requires adjusting the code to handle whether the response is nil or not.

Expected result
when http client timeout it return not nil response

Actual result
return nil

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions