Make CameraManager request the camera access permission when using Qt 6 #2381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camera access seems to have changed to require explicitly asking for permission rather than doing it for you. Starting the session was moved to the camStart slot so that the permission prompt will show up when the camera is actually used the first time rather than in some cases before the main window even shows up.
Checking for an unknown feature causes a division by zero
Contributor
|
LGTM, though I can't really test it myself, I think? |
Contributor
|
"Camera Settings" seems to work no worse than it did on my Linux machine (it can capture the camera), at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Camera access seems to have changed to require explicitly asking for permission rather than doing it for you.
Starting the session was moved to the camStart slot so that the permission prompt will show up when the camera is actually used the first time rather than in some cases before the main window even shows up.