Merged
Conversation
OpenAPI 3.0 specifically states items must be a Schema (if specified).
OpenAPI 3.1 (by default) uses a more recent Json Schema;
- items must be a Schema (if specified).
Both OpenAPI versions allow properties to be treated as an empty array.
Only OpenAPI 3.1 has prefixItems, which cna be treated as an empty array.
carnage
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies
items:OpenAPI 3.0 explicitly states that
itemsmust not be an array.OpenAPI 3.1 depends on a later version of the Json Schema which does not allow
itemsto be an array.Adds
formatUseful for Membrane core
Tests getRelevantMinimum and getRelevantMaximum
This required updating the PartialHelper to allow constructing with all of the keywords for 3.0