Merged
Conversation
2647c83 to
88427b2
Compare
88427b2 to
716e110
Compare
carnage
approved these changes
Nov 15, 2024
716e110 to
0c972a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We may need to consider how to make this consistent:
null would imply
typehas not been specified, thus can be any type.In 3.1 null is a type, so not specifying
typemeans that null is acceptable.But in 3.0 null is not a type,
nullableis a keyword. So iftypeis unspecified, butnullableis set to false... null is not acceptable.openapi-reader/src/ValueObject/Valid/V30/Schema.php
Lines 150 to 154 in 88427b2
Therefore, not specifying
typehas different meaning, depending on the version.Proposed Solution
We have getTypes() return all acceptable types.
Advantages
Disadvantages
We cannot rely on getTypes() to tell if it was unspecified.
To know if a type was specified, we would have to look at the property
$type.Thus we would want something like this when using it: