Conversation
charjr
force-pushed
the
own-api-objects
branch
6 times, most recently
from
259aaa1 to
502ea4f
Compare
charjr
force-pushed
the
own-api-objects
branch
2 times, most recently
from
63455a9 to
d0c34ca
Compare
- Partial Operations must now be passed explicitly to appropriate method
charjr
force-pushed
the
own-api-objects
branch
from
d0c34ca to
c10dbf0
Compare
charjr
force-pushed
the
own-api-objects
branch
from
bc6bb93 to
1a158b8
Compare
charjr
force-pushed
the
own-api-objects
branch
from
0952a29 to
8339793
Compare
charjr
force-pushed
the
own-api-objects
branch
7 times, most recently
from
cdc6dcd to
237ed88
Compare
- Add Server Variable Objects - Add Membrane Reader - Add CebeReader which takes original Reader logic - Refactor Reader to extend CebeReader
charjr
force-pushed
the
own-api-objects
branch
from
237ed88 to
03f386f
Compare
- Code coverage driver not currently found on Github
- Make use of new Parameter methods isIdentical and isSimilar
- Membrane now supports all Methods so "unsupportedMethod" is redundant
- The Exception folder only has static constructors. All these mutations are doing is changing the Exception message.
- Use Parameter methods for Parameter-specific logic
- Same behaviour but it can check multiple types at once
- test it warns against having no acceptable data types
- Avoid throwing warning unless no data type appropriately matches style
carnage
reviewed
Apr 17, 2024
carnage
approved these changes
Apr 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #8
todo to work with Membrane core