Skip to content

Remove unnecessary logging #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johanflint wants to merge 1 commit into from
Closed

Remove unnecessary logging #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/WidgetName/widget/WidgetName.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,12 @@ define([

// dijit._WidgetBase.postCreate is called after constructing the widget. Implement to do extra setup work.
postCreate: function() {
console.log(this.id + ".postCreate");
this._updateRendering();
this._setupEvents();
},

// mxui.widget._WidgetBase.update is called when context is changed or initialized. Implement to re-render and / or fetch data.
update: function(obj, callback) {
console.log(this.id + ".update");

this._contextObj = obj;
this._resetSubscriptions();
this._updateRendering();
Expand Down Expand Up @@ -126,7 +123,7 @@ define([
//TODO what to do when all is ok!
},
error: dojoLang.hitch(this, function(error) {
console.log(this.id + ": An error occurred while executing microflow: " + error.description);
console.error(this.id + ": An error occurred while executing microflow: " + error.description);
Copy link
Contributor

@dson dson Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Console messages are not visible to the user. I think it's better to either remove the error handler completely (the client will then take care of it) or use mx.ui.error to show a message to the user.

})
}, this);
}
Expand Down