Fixed bug - editor not disabled#23
Merged
JelteMX merged 1 commit intomendixlabs:masterfrom Feb 12, 2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
My name is Andrej Gajduk, I am a mendix consultant for Mensystems. We are using BootstrapRTE widget in our mendix application.
I noticed the following bug:
When the context object takes longer to load, the Bootstrap components gets initilized as editable.
When the context object is finally loaded setting the readonly flag has no effect.
My fix for this was to disable the bootstrapcomponent explicitly, when the context object is loaded - only if neccessary and only if it has been constructed.
I tested this locally and it seems to work without issues. Here is the revised code, its really not a lot. I hope that you can also update the version on the App Store soon.
-Andrej