Refactor Fan control #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced FANControlToggleComponent to enable/disable fan control. - Added FANUseProfileComponent and FANManageProfileComponent for managing fan profiles. - Updated localization files to include new strings for fan control and profile management. - Refactored fan mode handling to default to AUTO instead of NOCONTROL.
- Removed standalone FANControlToggleComponent and integrated its functionality into FANComponent. - Updated the toggle field to manage fan control state directly within FANComponent. - Simplified state management for fan control enabling/disabling.
- Added logic to reset all fans to auto when switching fan control from enabled to disabled. - Improved state management by tracking previous fan control status before changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.