refactor: simplify core session structure#256
Merged
augustoccesar merged 4 commits intonextfrom Mar 11, 2026
Merged
Conversation
augustoccesar
changed the title
augustoccesar
force-pushed
the
augustoccesar/simplify-session-entities
branch
from
11c12f9 to
e703249
Compare
Druue
approved these changes
Mar 10, 2026
linkup-cli/src/local_config.rs
Outdated
There was a problem hiding this comment.
the tiniest of nits:
we could rename stuff like this as now the concept of StorableDomain no longer exists but 🤷♀️
Member
Author
There was a problem hiding this comment.
Absolutely! Missed those 😅 Nice catch!
Changed on ccc8585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main focus on this PR is to reduce the duplication of structs on
linkup/src/session.rsand the cascade effects of doing so.