Skip to content

tidy up: semantic whitespace for improved-chroot #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stagnation merged 1 commit into from
Apr 15, 2025
Merged

tidy up: semantic whitespace for improved-chroot #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/improved-chroot-in-buildbarn/chroot-in-buildbarn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ The well-known family of `/dev/null`, `/dev/random`, and so on.
They are not technically _mounted_, but created through `mknodat`.

Runner.jsonnet [runner proto documentation]:

[runner proto documentation]: https://github.com/buildbarn/bb-remote-execution/blob/96c4fdce659fabfaba7ee2a60fd4e2ffab8352e2/pkg/proto/configuration/bb_runner/bb_runner.proto#L39

```js
{
chrootIntoInputRoot: true,
Expand All @@ -39,7 +41,9 @@ Runner.jsonnet [runner proto documentation]:
```

Worker.jsonnet [worker proto documentation]:

[worker proto documentation]: https://github.com/buildbarn/bb-remote-execution/blob/96c4fdce659fabfaba7ee2a60fd4e2ffab8352e2/pkg/proto/configuration/bb_worker/bb_worker.proto#L258

```js
{
...
Expand Down
6 changes: 3 additions & 3 deletions docs/improved-chroot-in-buildbarn/implementing-unmountat.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ Quote the manpages:
This is where we start to implement "unmountat",
the idea is to

A1: pick up the mount from the directory
A1: pick up the mount from the directory
A2: delete the mount

B1: pick up the mount from the directory
B2: move it somewhere else
B1: pick up the mount from the directory
B2: move it somewhere else
B3: unmount it from there

C1: emulate `umountat` with `fchdir` + `umount`
Expand Down