-
Notifications
You must be signed in to change notification settings - Fork 5
Command to delete flink jobs #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@janelletavares How difficult possible would it be to rework the To clarify, not a necessary change as this will likely change in the future when we might eventually incorporate into |
|
@justmisosoup It's a fairly low effort change overall. Though that does raise a question about how we should refer to jobs in documentation/help text. Instead of
should it be something like
that feels non-specific. |
|
@ericcheatham Good point. Articulating Today, that looks like in the Meroxa CLI: And in the documentation itself: https://docs.meroxa.com/cli/cmd/meroxa-apps#see-also Looking forward to the future for when Flink is eventually encapsulated under cc: @janelletavares |
|
@justmisosoup I believe it's a one-liner to change |
jayjayjpg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads great, thank you for putting this work together so quickly!
| } | ||
| } | ||
|
|
||
| func TestRemoveFlinkJobExecution(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice test coverage! ✨
| return GenerateResourceWithNameAndStatus("", "") | ||
| } | ||
|
|
||
| func GenerateFlinkJob() meroxa.FlinkJob { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I was already wondering how you can mock out a flink job in those unit tests 👀
Description of change
Don't let the papi db get cluttered without a way to clean it up.
Fixes https://github.com/meroxa/turbine-project/issues/291
Type of change
How was this tested?
Demo
Additional references
Documentation updated