feat(flink): add command for listing flink jobs #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

janelletavares merged 7 commits into master from jj/listed-as-flink

May 31, 2023

Contributor

jayjayjpg commented May 31, 2023 •

edited

Loading

Description of change

Fixes https://github.com/meroxa/turbine-project/issues/290

With this change, we're adding the meroxa flink list command to the CLI. This way, users will be able to see a list of their already deployed Flink jobs on the platform.

Type of change

New feature
Bug fix
Refactor
Documentation

How was this tested?

Unit Tests
Tested in staging
Tested in minikube

Open todos

add additional test cases for command failure
add tests for empty list
create demo

Demo

$ meroxa flink list
UUID                                    NAME              ENVIRONMENT       STATE             DEPLOYMENT STATE        
====================================== ================ ================== ================  ====================== 
118c7446-e60c-49a7-ac90-12e04d64df9e   my-first-flink       common           running           deployed                     
cb7a7d7c-8bb3-4549-9af7-4f9eaab9c2af   my-second-flink      common           failed            rolling back

jayjayjpg force-pushed the jj/listed-as-flink branch 2 times, most recently from 94f30c1 to b4b680c Compare

May 31, 2023 09:52


          feat(flink): add command for listing flink jobs

d78c4ae

jayjayjpg force-pushed the jj/listed-as-flink branch from b4b680c to d78c4ae Compare

May 31, 2023 10:14

jayjayjpg requested review from janelletavares, nassor, raulb and samirketema

May 31, 2023 10:16


          upd(flink): cleanup code comments and obsolete functions

843654c

jayjayjpg force-pushed the jj/listed-as-flink branch from abe5127 to 843654c Compare

May 31, 2023 10:21

jayjayjpg added the ready for review label

janelletavares reviewed

View reviewed changes

cmd/meroxa/root/flink/list.go Outdated Show resolved Hide resolved

janelletavares reviewed

View reviewed changes

cmd/meroxa/root/flink/list.go Outdated Show resolved Hide resolved

janelletavares reviewed

View reviewed changes

cmd/meroxa/root/flink/list_test.go Outdated Show resolved Hide resolved

janelletavares reviewed

View reviewed changes

cmd/meroxa/root/flink/list_test.go Outdated Show resolved Hide resolved

janelletavares reviewed

View reviewed changes

cmd/meroxa/root/flink/list_test.go Show resolved Hide resolved

Contributor

janelletavares commented May 31, 2023

looking good

jayjayjpg and others added 4 commits

May 31, 2023 17:43


          upd(flink): update dashboard reference in flink list output

3e3986f

Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>


          upd(flink): reorder imports in list test

10e693c

Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>


          upd(flink): remove obsolete append for flink jobs

7add125

Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>


          upd(flink): improve flink list test assertions

1e73912

Co-authored-by: Janelle Tavares <janelletavares@users.noreply.github.com>

nassor reviewed

View reviewed changes

utils/display/flink_jobs.go Outdated Show resolved Hide resolved


          fix(flink): update table header notation

3c9186a

jayjayjpg force-pushed the jj/listed-as-flink branch from 9635d8b to 3c9186a Compare

May 31, 2023 17:19

jayjayjpg requested review from janelletavares and nassor

May 31, 2023 17:20

janelletavares approved these changes

View reviewed changes

nassor approved these changes

View reviewed changes

janelletavares merged commit c6e1dea into master

janelletavares deleted the jj/listed-as-flink branch

May 31, 2023 19:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

raulb Awaiting requested review from raulb

samirketema Awaiting requested review from samirketema

2 more reviewers

nassor nassor approved these changes

janelletavares janelletavares approved these changes

Labels

ready for review