Skip to content

Conversation

@janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Jun 9, 2023

Description of change

the process library may not detect all of the potential errors in the command it's running. we need to look at stderr explicitly.

Fixes #770

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

BEFORE

$ meroxa apps run
<_InactiveRpcError of RPC that terminated with:
status = StatusCode.UNKNOWN
details = "json: cannot unmarshal object into Go struct field fixtureRecord.Key of type string"
debug_error_string = "UNKNOWN:Error received from peer {created_time:"2023-06-08T16:49:06.304472766-07:00", grpc_status:2, grpc_message:"json: cannot unmarshal object into Go struct field fixtureRecord.Key of type string"}"

e(2023) janelle@janelle-thinkpad:~/go/src/github.com/meroxa/turbine-examples/python/notion-s3-python (restore-python-actions) $ echo $?
0 |

AFTER

$ m apps run
Error: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.UNKNOWN
	details = "json: cannot unmarshal object into Go struct field fixtureRecord.Key of type string"
	debug_error_string = "UNKNOWN:Error received from peer  {created_time:"2023-06-09T08:00:34.482320432-07:00", grpc_status:2, grpc_message:"json: cannot unmarshal object into Go struct field fixtureRecord.Key of type string"}"
>

(2023) janelle@janelle-thinkpad:~/go/src/github.com/meroxa/turbine-examples/python/notion-s3-python  (restore-python-actions) $ echo $?
1

Screenshot from 2023-06-09 12-05-11

Additional references

Documentation updated

@janelletavares janelletavares merged commit f5dd05a into master Jun 9, 2023
@janelletavares janelletavares deleted the turbine-core-request-exit-codes branch June 9, 2023 19:36
janelletavares added a commit that referenced this pull request Jun 9, 2023
janelletavares added a commit that referenced this pull request Jun 9, 2023
janelletavares added a commit that referenced this pull request Jun 10, 2023
janelletavares added a commit that referenced this pull request Jun 10, 2023
janelletavares added a commit that referenced this pull request Jun 14, 2023
* Exit 1 when grpc requests fail (#771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed turbine-core requests do not result in non-zero process return values

3 participants