Skip to content

Turbine-go needs to be v2 #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janelletavares merged 1 commit into from
Jun 15, 2023
Merged

Turbine-go needs to be v2 #778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dispatch_turbine_go_dependency.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
git config --global url."https://${MEROXA_MACHINE}:x-oauth-basic@github.com/".insteadOf "https://github.com/"
- name: Update Dependencies
run: |
go get -u github.com/meroxa/turbine-go@latest
go get -u github.com/meroxa/turbine-go/v2@latest
make gomod
- name: Generate Branch name
id: branch
Expand All @@ -46,4 +46,4 @@ jobs:
github_token: ${{ secrets.MEROXA_MACHINE }}
pr_label: "ktlo,ready for review"
pr_title: "chore: Upgrade to latest turbine-go"
pr_body: "The following commands were run to generate changes: go get -u github.com/meroxa/turbine-go@latest and make gomod"
pr_body: "The following commands were run to generate changes: go get -u github.com/meroxa/turbine-go/v2@latest and make gomod"
2 changes: 1 addition & 1 deletion cmd/meroxa/turbine/golang/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func (t *turbineGoCLI) GetVersion(ctx context.Context) (string, error) {
cmd = exec.CommandContext(
ctx,
"go",
"list", "-m", "-f", "'{{ .Version }}'", "github.com/meroxa/turbine-go")
"list", "-m", "-f", "'{{ .Version }}'", "github.com/meroxa/turbine-go/v2")
cmd.Dir = t.appPath
fmtErr := fmt.Errorf(
"unable to determine the version of turbine-go used by the Meroxa Application at %s",
Expand Down