bug: use spinning logs correctly in flink deploy command #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samirketema
approved these changes
Aug 8, 2023
Contributor
samirketema
left a comment
samirketema
left a comment
There was a problem hiding this comment.
looks good. unfortunately the lint error says the size of Execute() is one line over the limit 😄
added 2 commits
August 8, 2023 18:16
janelletavares
changed the title
Contributor
|
Thank you! @janelletavares |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
when the start and stop spinners don't line up, log lines get garbled
Fixes https://github.com/meroxa/product/issues/959
Type of change
How was this tested?
Demo
|
|
|
Additional references
Documentation updated