compilers: Pass mode to determine_args, not its string value #13686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always pass the string value of the mode to determine_args, which causes the check on the mode argument inside determine_args to always evaluate to false. Fix this by passing the mode itself, not its value.
Contributor
Author
|
Pushing this up to CI in order to get a sense of its test impact. Also the commit message could use some clarification work but I'm not sure what would be best there. |
dcbaker
approved these changes
Sep 17, 2024
Member
dcbaker
left a comment
dcbaker
left a comment
There was a problem hiding this comment.
I wonder why mypy isn't catching this
Contributor
Author
It's definitely strange. I wonder if mypy is able to account for the indirection introduced by this code-path's use of Update: support was recently added to mypy for |
Member
|
The support for functools.partial also has huge gaps and flags all sorts of completely correct code as problematic. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always pass the string value of the mode to
determine_args, which causes the check on the mode argument insidedetermine_argsto always evaluate to false.Fix this by passing the mode itself, not its value.
Discovered this while investigating #13610. I noticed that
determine_argsis always called with a string as itsmodeargument, causing the condition at line 275 to always evaluate to false:https://github.com/amcn/meson/blob/2b80d4cca174916a4b6d0c47c54ad56795741bb6/mesonbuild/interpreter/compiler.py#L266-L280