Only upload simularium file once #446
Open
+24
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
ascibisz
changed the base branch from
feature/server-passed-recipe-json
to
feature/firebase-lookup
ascibisz
changed the base branch from
feature/firebase-lookup
to
feature/server-passed-recipe-json
ascibisz
force-pushed
the
fix/only-upload-simularium-file-once
branch
from
03cba71 to
5bb7d6f
Compare
ascibisz
changed the base branch from
feature/server-passed-recipe-json
to
feature/firebase-lookup
Base automatically changed from
feature/firebase-lookup
to
feature/server-passed-recipe-json
January 29, 2026 21:12
ascibisz
force-pushed
the
fix/only-upload-simularium-file-once
branch
from
ad9876a to
f648a2f
Compare
rugeli
reviewed
Feb 3, 2026
| sub_folder_name=sub_folder, | ||
| region_name="us-west-2", | ||
| ) | ||
| initialized_handler = handler( |
rugeli
approved these changes
Feb 3, 2026
Collaborator
rugeli
left a comment
rugeli
left a comment
There was a problem hiding this comment.
looks good to me! since store_matadata and upload_result_metadata are being removed next. the changes in here are very clean and well scoped!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're currently uploading the simularium results file twice for packings run on the cellpack server, once on its own to the /simularium subdirectory and once with all the output files to the /runs subdirectory. This is redundant and silly!
Link to story or ticket
Solution
When we're running a packing on the cellpack server, skip the step where we upload the simularium file on its own. When we upload the results directory, keep track of the path for the simularium file within that and upload that to firebase, along with the output files directory path.