Update SelectQuery interface to closely resemble core database API #9
Conversation
There are many things SOQL cannot do, but we can get pretty close to mimicing Drupal database layer. This commit updates SelectQuery to rely on Drupal\Core\Database\Query\Condition records to keep track of where clauses, and implements as many other methods as make sense from Drupal\Core\Database\Query\SelectInterface. Change namespace to Drupal\salesforce\Query\ Add a SelectQueryTest unit test to verify expected syntax for SOQL queries. Update all other uses of SelectQuery to reflect API changes. Still TODO: - update 8.x-3.x branch to deprecate uses of properties and methods being removed here - create change records - test these changes in more realistic scenarios
| @@ -0,0 +1,240 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Not sure I understand the purpose of this one. What's the advantage over just using apiCall directly?
If we're trying to move to be more Core-DB-like raw strings should probably be handled in RestClient::query
There was a problem hiding this comment.
Implemented this so to be compatible with RestClient::query, which requires a SelectInterface argument.
There's no real value in having this class - could just as easily move the layer of indirection to RestClient.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function addTable($table, $alias = NULL) { |
There was a problem hiding this comment.
Can we actually add tables in this fashion? I think this might have to be handled on the field list
There was a problem hiding this comment.
Yeah, sort of, e.g. if you want to add a table in order to create a where condition, but not select anything from it.
Here's an example query from https://developer.salesforce.com/docs/atlas.en-us.soql_sosl.meta/soql_sosl/sforce_api_calls_soql_alias.htm?search_text=alias
SELECT count()
FROM Contact c, c.Account a
WHERE a.name = 'MyriadPubs'
PR for https://www.drupal.org/node/2879844
There are many things SOQL cannot do, but we can get pretty close
to mimicing Drupal database layer. This commit updates SelectQuery
to rely on Drupal\Core\Database\Query\Condition records to keep track
of where clauses, and implements as many other methods as make sense
from Drupal\Core\Database\Query\SelectInterface.
Change namespace to Drupal\salesforce\Query\
Add a SelectQueryTest unit test to verify expected syntax
for SOQL queries.
Update all other uses of SelectQuery to reflect API changes.
Still TODO:
and methods being removed here