Fix: First startup frame latency & Frame Timing#105
Merged
Conversation
IridescentRose
force-pushed
the
fix/startup_latency
branch
from
a172189 to
c6409eb
Compare
IridescentRose
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latency goes from ~37.9 milliseconds on my M4 Air to ~210 microseconds, which is noticeably snappy. I also suspect a bug in some of the frame / input timing code but will make a separate PR after investigating.
EDIT: Since it mostly interferes with the code I just wrote, it's better to probably put it in this PR. The issue is that frame drift can occur and the timing is imprecise. We did lose one behavior which is immediate repaint on character keystroke; this means maximally a 16ms input lag, which should be acceptable.
EDIT 3: Deleted an incorrect comment -- Linux startup was also impacted by this issue but my local cached version was broken.