Fix: Remove error union from Program.init*#107
Open
IridescentRose wants to merge 1 commit into
Open
Conversation
af22ab9 to
78efdf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing my TUI application I noticed my refactored main had some code that looked like it shouldn't compile:
trywithout!u8as the return type should fail in most contexts; The reason it doesn't here is because the error set is{}-- there are no possible errors from the code path.Checking
init, nothing currently throws an error, it's all infallible struct initialization. Reflecting this appropriately in the type signature keeps the API honest to the real behavior, as it currently is impossible to throw an error. If at some point this changes, error-unions can be reintroduced then.