Browsing | Handle long item names in the sidebar #21063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## prototype-starting-points #21063 +/- ##
============================================================
Coverage ? 64.75%
============================================================
Files ? 2289
Lines ? 76440
Branches ? 9241
============================================================
Hits ? 49496
Misses ? 23068
Partials ? 3876
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
daltojohnso
approved these changes
Mar 17, 2022
Contributor
daltojohnso
left a comment
daltojohnso
left a comment
There was a problem hiding this comment.
Seems like this might be a good opportunity to use a Tooltip to show the full name
Contributor
Author
Great idea, thank you! Just pushed it. @kdoh please take a look:
|
kulyk
added a commit
that referenced
this pull request
Mar 30, 2022
* Prototype new nav skeleton (#20875) * yarn * begin basic layout flip * rough in collections list * position query builder * remove fitViewport from QB to fix layout quirks * extract search * clean up props * position search / style * fix dashboard layout * fix search icon * move ProfileLink * tweak spacing * fix burger * add basic toggle * tweak layout for sidebar toggle * tweak style * tweak sidebar sizing * Quick fix to prototype starting points init (#20922) * fix scroll overflow on sidebar Co-authored-by: Gustavo Saiani <gustavo@poe.ma> * add currentUser to profile link * move footer items out of collection sidebar * tweak footer style * fix hover style * clean up footer * fixup * remove un-needed overflow hidden * hide app bar when in admin mode * merge sidebar header into new color scheme / nav layout * clean up headers * fix root collection spacing * smaller font size for nav items * provide flex context, fixes metadata editing * fix login page * Remove console logs * Put user's personal collection under Our analytics (#21061) * Browsing | Handle long item names in the sidebar (#21063) * Handle long names in the nav sidebar * Show tooltip with a full item name if its cut * Browsing | Fix data reference & admin permissions layout (#21101) * Remove admin navbar CSS fix * Handle admin navbar in root App component * Extract styled components * Fix data reference layout * Fix main container height * Browsing | Hide sidebar for questions, models and dashboards on page open (#21064) * Manage default sidebar visibility * Handle ad-hoc questions better * Move nav elements based on feedback (#21190) * scoot buttons around * move logo to appbar, scoot search * remove user footer, home link [ci skip] * review feedback [ci skip] * fix accidental removal of links (minimalism was a fad anyway) (#21192) * add button classes to new button (#21213) * Nav visual changes (#21223) * switch nav bg + move styling to NavRoot * readable text * increase contrast * selected icon color * remove bottom padding * search bar color * restructure sidebar position * fix sidebar header color * move to fixed when small * fix multiple scrollbars * fix sidebar width * home as own item, gear below * fix admin nav * extract nav constant, fix types * remove unused constant [ci skip] * New nav - get base colors in order (#21262) * new sidebar button * nav bg to bg-light * fix link track, remove extra home link * color tweaks * swap colors * Fix E2E tests for new navigation UI (#21196) * Use `main` HTML tag for main page content * Add extra UI helpers for Cypress * Fix tests failing due to nav UI changes * Remove not needed NavBar code * Fix loading databases list * Use `navigationSidebar` helper for collections * Use `navigationSidebar` for collection tests * Close sidebar in SQL filters tests * Extract AppBar component to `metabase/nav` * Fix test * Fix test * Skip sidebar visibility control test * Fix JSON engine DB check * Fix DatasetEditor edit bar colors * Fix global containers heights * Fix tests scrolling target * Fix styles * Fix navbar cypress helpers * [ci nocache] * Fix scroll in e2e test * Browsing | Manage sidebar state with redux (#21226) * Move navbar state to redux * Hide sidbebar using CSS * Fix native E2E test * Fix native e2e test * Fix model tests * Use more accurate element getters * Fix e2e tests * Browsing | Fix dashboard UI (#21233) * Fix parameter widgets event listeners * Attach scroll events to "main" instead of window * Resize filters panel when navigation sidebar open * Reorder imports at App * Hide AppBar and NavBar when editing dashboard * Fix navbar & appbar visibility * Fix filter positions * Extract `getMainElement` helper * Update unit tests * Fix test * Browse fix bulk actions (#21320) * make bulk action bar aware of sidebar, remove extraneous layout components * clean up styling * convert BulkActionBar to tsx * Fix types Co-authored-by: Kyle Doherty <5248953+kdoh@users.noreply.github.com> Co-authored-by: Gustavo Saiani <gustavo@poe.ma> Co-authored-by: Aleksandr Lesnenko <alxnddr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it ellipsify long item names in the sidebar (bookmarks and collections)
To Verify
Demo
Before
After
