Fix Docker image build cache dependencies #598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilds The Docker Hub workflow had several issues preventing images from building correctly when there was no local cache: 1. Each `docker buildx bake` call was independent, so dependent images (dev->deps, runtime->dev, cli->runtime) couldn't find their base images 2. Syntax error in manifest creation loop (missing opening quote) 3. Deprecated `::set-output` GitHub Actions syntax Changes: - Add docker-bake.hcl with proper target dependencies using `contexts` to allow BuildX to resolve image dependencies within a single build - Update sub_platform() to use single bake command instead of 4 separate calls - Add Dockerfile.dockerignore files for BuildKit's per-dockerfile ignore support - Fix syntax error in docker-hub.yml manifest creation - Update to modern $GITHUB_OUTPUT syntax - Add depends_on to docker-compose.yml for proper service ordering
The test step was failing because docker buildx was trying to pull metacall/core:cli from Docker Hub instead of using the locally built image. This happened because buildx for cross-platform builds doesn't automatically resolve base images from the local Docker daemon. Use --build-context with docker-image:// prefix to explicitly tell buildx to use the local image as the base for the test Dockerfile.
The --build-context with docker-image:// still fails because buildx tries to match platform metadata in the manifest. Instead, run tests directly in the container using docker run with --platform flag. QEMU is already configured from the bake step, so cross-platform container execution works via emulation. This completely avoids the buildx base image resolution issues for cross-platform builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uilds
The Docker Hub workflow had several issues preventing images from building correctly when there was no local cache:
Each
docker buildx bakecall was independent, so dependent images (dev->deps, runtime->dev, cli->runtime) couldn't find their base imagesSyntax error in manifest creation loop (missing opening quote)
Deprecated
::set-outputGitHub Actions syntaxChanges:
contextsto allow BuildX to resolve image dependencies within a single buildDescription
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.
Fixes #(issue_no)
Type of change
Checklist:
make testorctest -VV -R <test-name>)../docker-compose.sh test &> outputand attached the output.OPTION_BUILD_ADDRESS_SANITIZERor./docker-compose.sh test-address-sanitizer &> outputandOPTION_TEST_MEMORYCHECK.OPTION_BUILD_THREAD_SANITIZERor./docker-compose.sh test-thread-sanitizer &> output.Helgrindin case my code works with threading.make clang-formatin order to format my code and my code follows the style guidelines.If you are unclear about any of the above checks, have a look at our documentation here.