Remove security.User from auditing and split http/grpc/connect#206
Conversation
majst01
requested review from
Gerrit91 and
vknabel
and removed request for
a team
majst01
force-pushed
the
remove-security-from-auditing
branch
from
f56382a to
4dd9033
Compare
majst01
force-pushed
the
remove-security-from-auditing
branch
from
4dd9033 to
97958d4
Compare
| type User struct { | ||
| EMail string | ||
| Name string | ||
| Groups []string |
There was a problem hiding this comment.
In the audit backend I don't think we need this.
| Groups []string | ||
| Tenant string | ||
| Project string | ||
| Issuer string |
There was a problem hiding this comment.
This can also be dropped.
majst01
force-pushed
the
remove-security-from-auditing
branch
from
ad7b1ed to
bcff434
Compare
| Include string = "include-to-auditing" | ||
| // Exclude explicitly excludes the request to the auditing backend even if the request method would audit the request (only applies for the http filter) | ||
| Exclude string = "exclude-from-auditing" | ||
| RequestLoggerKey Key = iota |
There was a problem hiding this comment.
As this seems to come from the rest package with a logger that can only be used with go-restful, I think we can remove it from this package. The RequestIDKey we can keep as it allows people to access the generated ID or provide an own request ID.
| err = a.Index(auditReqContext) | ||
| return resp, err | ||
| }, nil | ||
| type auditingConnectInterceptor struct { |
There was a problem hiding this comment.
Would it make sense to also split apart the connect interceptors to make files a bit smaller and to allow pure gRPC people to use them without having to import connect as a dependency to their projects?
There was a problem hiding this comment.
was thinking about that as well
3 participants
Description
With MEP-4 we want to get rid of
github.com/emicklei/go-restfulbut with auditing we inherit this dependency.Therefore we need to:
See
for effective usage
Used AI-Tools ✨