fix: install missing frr-reload.service on dell_sonic leaves#295
Merged
Conversation
iljarotar
approved these changes
Apr 28, 2026
Gerrit91
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The dell_sonic integration runs failed because of a missing dell_sonic frr-reload.service according to #279.
I tracked down the recent commits when the pipe started failing:
The
metal-coreAnsible role doesn't deploy thefrr-reload-serviceanymore: https://github.com/metal-stack/metal-roles/pull/479/changes.The
sonicAnsible role was deprecated and replaced withsonic-config, which deploys it now - but not on dell_sonic switches in the mini-lab: https://github.com/metal-stack/mini-lab/pull/272/changes#diff-e5a9ca7487c5ffd979ceb6ae78ca57e297f588eb7c5a4678c2396730566d4664.When installing it on the dell_sonic switches, tests run fine again.
References:
Needed by metal-stack/cluster-api-provider-metal-stack#137
Closes #279