Make Lifecycle ignore repeated stop requests#28
Merged
Conversation
Contributor
There was a problem hiding this comment.
Should this be an error? I think unlike stop, there's no good reason for start to be called multiple times
Contributor
Author
There was a problem hiding this comment.
Maybe? Prior behavior did not throw an error, which is why I did not do so here.
Contributor
There was a problem hiding this comment.
I feel like it makes sense to either not change the behavior, or to have it throw an error; silently skipping over double starts seems sketchy. At least the old behavior would probably blow up in some way and let us know something was being done wrong.
drcrallen
force-pushed
the
idempotentLifecycle
branch
from
639ad15 to
ae0a6af
Compare
drcrallen
changed the title
drcrallen
force-pushed
the
idempotentLifecycle
branch
from
ae0a6af to
24765c5
Compare
Contributor
|
👍 |
Contributor
Author
|
Bouncing for travis |
Contributor
|
@drcrallen rebase on current master, it will help with travis |
drcrallen
force-pushed
the
idempotentLifecycle
branch
from
24765c5 to
5169b97
Compare
Contributor
Author
|
ding! winner |
xvrl
added a commit
that referenced
this pull request
Nov 12, 2015
Make Lifecycle ignore repeated stop requests
This was referenced Dec 18, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to apache/druid#1627