Conversation
There was a problem hiding this comment.
pls use newer license header
There was a problem hiding this comment.
can you either add another UT or update this so that field names are explicitly specified and resulting map has something else and not "column_1"?
|
@himanshug @gianm Addressed all comments |
fjy
force-pushed
the
master
branch
3 times, most recently
from
fe706a4 to
8d6407c
Compare
|
👍 |
There was a problem hiding this comment.
probably not a big issue, but if matching fails then user would get nested ParseException, one from line 92 then that will get wrapped inside another here, should we catch specific exceptions instead of Exception ? or may be add another catch for ParseException that simple throws that?
There was a problem hiding this comment.
the two levels of parseexceptions will tell you exactly what is wrong and where it is wrong. I tested this
6 participants
No description provided.