Make sure deprecation warnings don't reach users that can not act on them#205
Merged
Luthaf merged 1 commit intometatensor:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
|
Who will they reach then? 😄 |
Member
Author
|
Basically the issue was that end users would get a warnings when loading a model exported with an old version of metatomic. We only want the person exporting the model to get this warning, not someone just trying to run a simulation. |
Contributor
|
Ok I would say that this would be the normal way in which things work, end users see the warning, then post an issue and the client code updates to deal with it. I guess in this case since we control all the clients it might not be needed though, so ok 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #168
Contributor (creator of pull-request) checklist
Documentation updated (for new features)?Reviewer checklist
CHANGELOG updated with public API or any other important changes?