Unify pick_device between C++ and Python#209
Open
PicoCentauri wants to merge 1 commit intomainfrom
Open
Conversation
PicoCentauri
force-pushed
the
unify_pick_device
branch
from
e236f60 to
924a836
Compare
Member
|
I'm a bit concerned by this being a breaking change, and requiring again to scramble and update all engines … Maybe we should keep this open for now and bundle it together with other breaking changes later? |
Contributor
Author
Agree! But I think it is cleaner and better now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
pick_devicenow returns atorch::Device(allowing for a user supplied index) in both C++ and Python, instead of a bareDeviceTypein C++ and a reconstructed string in Python.The
pick_device_pywrapperin C++ is removed.📚 Download documentation for this pull-request